New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257208: Fix typo in doc/building.md #1365
Conversation
Hi @HollowMan6, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user HollowMan6" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
@HollowMan6 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Hi @HollowMan6! Thank you for submitting this PR. As the contribution docs state, you need a sponsor for this PR. I'll be your sponsor. I have opened a bug issue for this fix: https://bugs.openjdk.java.net/browse/JDK-8257208 Please update the PR title to |
Signed-off-by: Hollow Man <hollowman@hollowman.ml>
@magicus Done! Thanks. |
@HollowMan6 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 102 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@HollowMan6 |
@magicus Thanks for reviewing! Now could you please sponsor this change? Thanks! |
/sponsor |
@magicus @HollowMan6 Since your change was applied there have been 103 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f6bfbb2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
overriden -> overridden
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1365/head:pull/1365
$ git checkout pull/1365